Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This test checks that tail_watcher must be empty #2938

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Apr 8, 2020

Which issue(s) this PR fixes:
Fixes https://travis-ci.org/github/fluent/fluentd/jobs/670028558#L1924, https://travis-ci.org/github/fluent/fluentd/jobs/671897056#L746

What this PR does / why we need it:

This test checks that tail_watcher must be empty when the tailed file no longer exists.
No need to check object count since it's very fragile

Docs Changes:

no need

Release Note:

no need

when the tailed file no longer exists.
No need to check object count since it's very fragile

Signed-off-by: Yuta Iwama <[email protected]>
@ganmacs ganmacs self-assigned this Apr 8, 2020
@ganmacs ganmacs requested review from cosmo0920 and repeatedly April 9, 2020 00:44
@ganmacs ganmacs merged commit 07b2e24 into fluent:master Apr 9, 2020
@ganmacs ganmacs deleted the remove-object-count branch April 9, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants