Fix appveyor ci for round4 #2864
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
fix-appveyor-ci-for-round4
branch
from
c102e55 to
75a631c
Compare
|
Phew, we got green on AppVeyor! https://ci.appveyor.com/project/fluent/fluentd/builds/31285183 |
ganmacs
approved these changes
Mar 6, 2020
| @@ -196,7 +196,11 @@ def build_files(file) | |||
| @file.seek(0) | |||
| lines = @file.readlines | |||
| assert_equal 2, lines.size | |||
| assert_equal "valid_path\t000000000000000a\t000000000000000b\n", lines[0] | |||
| if Fluent.windows? | |||
| assert_equal "valid_path\t0000000000000000a\t000000000000000b\n", lines[0] | |||
There was a problem hiding this comment.
Aha! I got it.
In Windows, it is also needed to use binmode for Tempfile! 👊
cosmo0920
force-pushed
the
fix-appveyor-ci-for-round4
branch
from
75a631c to
5328234
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Winsock generates the different error message than Linux's. Signed-off-by: Hiroshi Hatake <[email protected]>
Because these test cases should handle same timestamp. We should sort with another sortable key such as tag. Signed-off-by: Hiroshi Hatake <[email protected]>
In Windows, writing 0 contained contents should be written as binmode. Otherwise, it will cause corrupted contents. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
fix-appveyor-ci-for-round4
branch
from
5328234 to
7560a48
Compare
|
I'll merge this PR after finishing CIs. 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Related to #2854.
What this PR does / why we need it:
We should take care of AppVeyor CI result.
Docs Changes:
No needed.
Release Note:
None.