Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_file: Revert #1995 changes #2842

Merged
merged 1 commit into from
Feb 26, 2020
Merged

out_file: Revert #1995 changes #2842

merged 1 commit into from
Feb 26, 2020

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa [email protected]

Which issue(s) this PR fixes:
No issues

What this PR does / why we need it:
This reverts #1995 changes. Recent fluentd doesn't have thread interruption issue for zlib.

Docs Changes:
No need

Release Note:
Same as title or put it in clean up code list.

Recent fluentd doesn't have thread interruption issue.

Signed-off-by: Masahiro Nakagawa <[email protected]>
@repeatedly repeatedly requested a review from ganmacs February 25, 2020 19:30
@repeatedly repeatedly self-assigned this Feb 25, 2020
Copy link
Member

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can revert #1995 because #2170 solved an issue. LGTM

@repeatedly repeatedly merged commit e67718f into master Feb 26, 2020
@repeatedly repeatedly deleted the revert-1995 branch February 26, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants