Prevent garbage from coming out of the LTSV parser #2748
Merged
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
I have not opened one yet.
What this PR does / why we need it:
The LTSV parser does not check whether the delimiter is in the pair before it tries to parse it. With
delimiter_pattern /\s+/
andlabel_delimiter =
,If I give it the value:it parses it like this:
Both
Sylvanus_007: null
and":": null
were never specified by key=value. This PR prevents this drastically wrong behavior and parses it like this:Docs Changes:
None
Release Note:
None