Remove unnecessary config reload #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganmacs
force-pushed
the
remove-unnecessary-config-reload
branch
2 times, most recently
from
a58a70c to
39c73f8
Compare
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Current implementation loads system_config parameters(rpc_endpoint, enable_get_dump, counter_server) in Supervisor.load_config which is called at ServerEngine creation time. And it can also reload config dynamically via serverengine's mechanism(sending signal USR2 to fluentd). These parameters can be reloadable but it doesn't make any changes to fluentd itself. fluentd document also doesn't mention about signal USR2. so it's no need to load in Supervisor.load_config. it's enough to pass the value at start time. Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
remove-unnecessary-config-reload
branch
from
39c73f8 to
c98b348
Compare
|
@ashie @cosmo0920 could you review this patch? |
|
nits: Which issue will be fixed by this PR?
|
Good catch… this is related to light config reloading mechanism. |
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Mar 9, 2023
It does not load the config anymore since fluent#2709, so it should simply returns the config for ServerEngine. Signed-off-by: Daijiro Fukuda <[email protected]>
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 12, 2024
Closes: fluent#1479 Feedback from @mszyzdek ref. fluent#1479 (comment) * graylog flavour of fluentd-kubernetes-daemonset uses gelf 3.0.0 and this version of gelf gem has Fixnum in code, graylog-labs/gelf-rb@7cc3cbb * in ruby 3.2 Fixnum was removed after previous deprecation in version 2.4 https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/ * ruby in newest fluentd was upgraded to 3.2 fluent/fluentd-docker-image@4f1d5e8 so it also happened in fluentd-kubernetes-daemonset * gelf 3.0.0 cannot work with ruby 3.2+ so we can see sad error on container start NOTE: Even though gelf was updated to 3.1.0, still it has problem with reloading Fluentd configuration with SIGUSR2. This is known issue since Fluentd 1.8.0. ref. fluent/fluentd#2709 Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 12, 2024
Closes: fluent#1479 Feedback from @mszyzdek ref. fluent#1479 (comment) * graylog flavour of fluentd-kubernetes-daemonset uses gelf 3.0.0 and this version of gelf gem has Fixnum in code, graylog-labs/gelf-rb@7cc3cbb * in ruby 3.2 Fixnum was removed after previous deprecation in version 2.4 https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/ * ruby in newest fluentd was upgraded to 3.2 fluent/fluentd-docker-image@4f1d5e8 so it also happened in fluentd-kubernetes-daemonset * gelf 3.0.0 cannot work with ruby 3.2+ so we can see sad error on container start NOTE: Even though gelf was updated to 3.1.0, still it has problem with reloading Fluentd configuration with SIGUSR2. This is known issue since Fluentd 1.8.0. ref. fluent/fluentd#2709 Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
ref #2624
What this PR does / why we need it:
Current implementation loads system_config parameters(rpc_endpoint,
enable_get_dump, counter_server) in Supervisor.load_config
which is called at ServerEngine creation time.
And it can also reload config dynamically via serverengine's
mechanism(sending signal USR2 to fluentd).
These parameters can be reloadable but it doesn't make any changes
to fluentd itself. fluentd document also doesn't mention about signal USR2.
so it's no need to load in Supervisor.load_config.
it's enough to pass the value at start time.
Docs Changes:
no need
Release Note:
no need