inline_config is replaced with the input value when user specify -
#2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation calling `STDIN.read` in supervisors and workers. it cause blocking in worker side. Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
fix-inline-conf
branch
from
bc06b94 to
d23bb68
Compare
|
could you review this patch? @cosmo0920 @ashie |
cosmo0920
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Looks good.
The following comment is nitpicks.
Feel free to ignore in this PR.
I hadn't use this this feature until now.
I got confused about this feature.
I expected that inline config is freshly and entirely used for Fluentd configuration.
However, currently, inline config is appended loaded Fluentd configuration.
This behavior got confuse for me.
|
True. I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
no
What this PR does / why we need it:
Current implementation calling
STDIN.readin supervisors and workers.it causes blocking in worker side.
Docs Changes:
no
Release Note:
same as the title .