Properly show class names #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Lee <[email protected]>
dlackty
force-pushed
the
time-error-class-name
branch
from
1e41887 to
3728cb1
Compare
ganmacs
approved these changes
Oct 29, 2019
|
Ah, good catch! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
We recently encountered a weird error showing that:
value must be a string or a number: (value.class)"After digging into the source code, I finally realized that I passed
nilinto the parser but the message was quite confusing.From my perspective, I thought
(value.class)should actually be(#{value.class}), which showed the class name of the value. In my case, it will be(NilClass), which should be clear for users to understand.Docs Changes:
None
Release Note:
None