-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ext_monitor gem to improve Monitor class's operations #2670
Conversation
I'll merge this after #2380 |
0f30378
to
5cea5ec
Compare
Signed-off-by: Yuta Iwama <[email protected]>
5cea5ec
to
d673f2f
Compare
7d1183a
to
5994f2c
Compare
By introducing ext_monitor in ruby 2.7, how about changing to |
5994f2c
to
d800743
Compare
Sorry, I had a mistake about a condition of installing.
Does it mean like below? and removing if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('2.7.0')
require 'monitor'
else
begin
require 'ext_monitor'
rescue LoadError => _
require 'monitor'
end
end |
Yes. |
06f6a91
to
4ae5416
Compare
fixed. This log always outputs to STDOUT without ext_monitor. it might be noisy. what do you think of that? @repeatedly |
Maybe, such message is not needed. Add to instruction to gem install article is enough. |
add move to dev dependency Signed-off-by: Yuta Iwama <[email protected]>
4ae5416
to
0a772f2
Compare
👍 fixed 0a772f2 |
Which issue(s) this PR fixes:
Fixes #2645
What this PR does / why we need it:
From ruby 2.6.5, Monitor class became slower due to fixing a deadlock bug (https://bugs.ruby-lang.org/issues/15992).
https://github.com/nurse/ext_monitor/ mitigates performance for ruby 2.6.5 or later and improves it for prior to 2.6.4 by 2x(#2645 (comment)).
Docs Changes:
no need
Release Note:
same as the title