Make engine lighter #2667
Merged
Make engine lighter #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of worker0 Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
make-engine-lighter
branch
2 times, most recently
from
9a5e96e to
30701c6
Compare
matches isn't needed since fluent@6b37daa#diff-a3660169e91ca999d07caabc1aac67c3 Signed-off-by: Yuta Iwama <[email protected]>
fluent@19f5b3e#diff-a3660169e91ca999d07caabc1aac67c3 Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
make-engine-lighter
branch
from
30701c6 to
46937aa
Compare
Signed-off-by: Yuta Iwama <[email protected]>
repeatedly
reviewed
Oct 28, 2019
|
|
||
| def graceful_stop; end | ||
|
|
||
| def emit_event; end |
There was a problem hiding this comment.
No argument. is it intended?
There was a problem hiding this comment.
Good catch! I missed adding an argument.
137f6b4
There was a problem hiding this comment.
should add test for NullFluentLogEventRouter methods?
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
repeatedly
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Ref #2624
What this PR does / why we need it:
Make engine lighter for safe reloading.
Docs Changes:
no need
Release Note:
no need