Suppress warning about keyword argument introduced from ruby 2.7 #2664
Conversation
ganmacs
force-pushed
the
for-ruby2.7
branch
2 times, most recently
from
01f3dc8 to
d6dab35
Compare
|
Warnings around keyword arguments look disappearing https://travis-ci.org/fluent/fluentd/jobs/602174792?utm_medium=notification&utm_source=github_status |
| @@ -53,13 +53,26 @@ def initialize(klass, opts: {}, &block) | |||
| @section_name = '' | |||
| end | |||
|
|
|||
| def configure(conf, syntax: :v1) | |||
| def configure(conf) | |||
There was a problem hiding this comment.
this change doesn't impact existing test cases?
There was a problem hiding this comment.
looks like so. this was introduced in #1047 . but I can't get any more information about why this method needs this parameter. so leave it as it is. and I will delete it when fluentd becomes v2. or you think it should be deleted in this PR?
There was a problem hiding this comment.
Maybe, this parameter is for testing the plugin with v1 and old syntax.
I'm not sure how many 3rd party plugins use this parameter...
There was a problem hiding this comment.
There is no problem for me because this is only for test, not for production code.
Failing test is not critical and easy to fix it.
Which issue(s) this PR fixes:
no
What this PR does / why we need it:
For https://bugs.ruby-lang.org/issues/14183
there are a vast number of warnings in https://travis-ci.org/fluent/fluentd/jobs/602120485 which is tested in ruby 2.7 preview2.
See also https://www.ruby-lang.org/en/news/2019/10/22/ruby-2-7-0-preview2-released/
Docs Changes:
no need
Release Note:
no need