Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to use instance variable #2653

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Oct 15, 2019

Which issue(s) this PR fixes:
Ref #2624

What this PR does / why we need it:

No need to use ivar since since #496 .

Docs Changes:

no need

Release Note:

no need

@ganmacs ganmacs requested a review from repeatedly October 15, 2019 09:35
@ganmacs ganmacs self-assigned this Oct 15, 2019
@repeatedly repeatedly merged commit 540f0a5 into fluent:master Oct 15, 2019
@repeatedly
Copy link
Member

Good

@ganmacs ganmacs deleted the not-to-use-ivar branch October 16, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants