formatter_csv: support nested fields. fix #2630 #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
ganmacs
approved these changes
Oct 10, 2019
| @@ -37,6 +41,14 @@ def configure(conf) | |||
| @fields = fields.select{|f| !f.empty? } | |||
| raise ConfigError, "empty value is specified in fields parameter" if @fields.empty? | |||
|
|
|||
| if @fields.any? { |f| record_accessor_nested?(f) } | |||
| @accessors = @fields.map { |f| record_accessor_create(f) } | |||
There was a problem hiding this comment.
How about this? it can avoid the needless call of Accessor#call. Not nested fields don't need to be called this method, right?
nested = @fileds.select { |f| record_accessor_nested?(f) }
unless nested.empty?
@accessors = nested.map { |f| record_accessor_create(f) }
...
endThere was a problem hiding this comment.
Your appoarch is bit complicated.
If fields are a,$.b.c,d, formatter_csv needs to remember the nested field position when separate fields into normal access and record_accessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa [email protected]
Which issue(s) this PR fixes:
Fixes #2630
What this PR does / why we need it:
Support nested fields via
record_accessor.Docs Changes:
Add note for nested fields to
fieldsparameter.Release Note:
same as title