in_syslog: Replace priority_key with proper severity_key #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
ganmacs
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Looks good.
https://tools.ietf.org/html/rfc5424 says
The number contained within these angle brackets
is known as the Priority value (PRIVAL) and represents both the
Facility and Severity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa [email protected]
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
I noticed
priority_keyis misleading name because it stores severity, not priority.So I add proper
severity_keyand keeppriority_keyfor backward compatibility.priority_keywill be removed at fluentd v2.Docs Changes:
Will add
severity_keyand deprecatepriority_keyRelease Note:
Same as title.