Reuse same hash object after calling purge_obsolete_socks #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since @available_sockets is initialized with
`Hash.new { |obj, k| obj[k] = [] }` at https://github.com/fluent/fluentd/blob/v1.7.1/lib/fluent/plugin/out_forward/socket_cache.rb#L27
Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
fix-bug-available-socket-value-can-be-nil
branch
from
0e81244 to
20c8a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since @available_sockets is initialized with
Hash.new { |obj, k| obj[k] = [] }at https://github.com/fluent/fluentd/blob/v1.7.1/lib/fluent/plugin/out_forward/socket_cache.rb#L27Which issue(s) this PR fixes:
Fixes #2626
What this PR does / why we need it:
to avoid NoMethodError after calling purge_obsolete_socks
Docs Changes:
no need
Release Note:
same as title