Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum msgpack version #2606

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Increase minimum msgpack version #2606

merged 1 commit into from
Sep 9, 2019

Conversation

jonahb
Copy link
Contributor

@jonahb jonahb commented Sep 6, 2019

9aca889 started using MessagePack::Packer#full_pack, which was introduced in msgpack 1.2.0.

@repeatedly
Copy link
Member

Could you follow DCO?

https://github.com/fluent/fluentd/pull/2606/checks?check_run_id=214610500

@jonahb
Increase minimum msgpack version
e55972b 
9aca889 started using MessagePack::Packer#full_pack, which was
introduced in msgpack 1.2.0.

Signed-off-by: Jonah Burke <[email protected]>
@jonahb
Copy link
Contributor Author

jonahb commented Sep 9, 2019

@repeatedly I have signed off

@repeatedly repeatedly merged commit aa54583 into fluent:master Sep 9, 2019
@repeatedly
Copy link
Member

Thanks! Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahb @repeatedly @ganmacs