Raise config error when using same file path in file_signle buffer #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if user passes `/path/to/foo.*.baz` to buffer plugin A as `path` directive, single file buffer convert it into `/path/to/fsb.*.buf`. in https://github.com/fluent/fluentd/blob/c7a825c7cad52f0c2a322ae88f7011e842b3d4fb/lib/fluent/plugin/buf_file_single.rb#L115-L117 Signed-off-by: Yuta Iwama <[email protected]>
repeatedly
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
if user passes
/path/to/foo.*.bazto single file buffer plugin aspathdirective, single file buffer convert it into
/path/to/fsb.*.buf.in here.
fluentd/lib/fluent/plugin/buf_file_single.rb
Lines 115 to 117 in c7a825c
When the user uses another single file buffer whose
pathis/path/to/in the above situation, single file buffer should raise anConfigError, but not in present implementation.Docs Changes:
no need
Release Note:
same as the title