Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to remove metadata if #write_metadata raise an error because of disk full #2598

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Sep 2, 2019

Which issue(s) this PR fixes:
Fixes #2593

What this PR does / why we need it:

Ensure to remove metadata if #write_metadata raise an error because of disk full

Docs Changes:

no need

Release Note:

same as the title

@repeatedly repeatedly added the bug Something isn't working label Sep 2, 2019
@ganmacs
Copy link
Member Author

ganmacs commented Sep 4, 2019

ping @repeatedly

@ganmacs ganmacs self-assigned this Sep 4, 2019
@repeatedly
Copy link
Member

repeatedly commented Sep 4, 2019

Looks good.
No review request, so I assumed this is incomplete.

@ganmacs
Copy link
Member Author

ganmacs commented Sep 4, 2019

No review request, so I assumed this is incomplete.

My bad.. I thought I assigned you as a reviewer.
Anyway, thank you for reviewing!

@ganmacs ganmacs merged commit 4a4b1cc into fluent:master Sep 4, 2019
@ganmacs ganmacs deleted the ensure-to-remove-metadata branch September 4, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluentd fails to cleanup buffer metadata
2 participants