Not to call Parser#configure is called twice #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First time is in parser helper https://github.com/fluent/fluentd/blob/5a7d94941371dddcb7150a73ddbe142102a68964/lib/fluent/plugin_helper/parser.rb#L82 Second time is parser_create in TailInput https://github.com/fluent/fluentd/blob/5a7d94941371dddcb7150a73ddbe142102a68964/lib/fluent/plugin/in_tail.rb#L151 Signed-off-by: Yuta Iwama <[email protected]>
|
Confirmed this patch works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuta Iwama [email protected]
Which issue(s) this PR fixes:
Fixes #2555
What this PR does / why we need it:
First time is in parser helper
fluentd/lib/fluent/plugin_helper/parser.rb
Line 82 in 5a7d949
localtimeis set in the first time. #2555 (comment))Second time is parser_create in TailInput
fluentd/lib/fluent/plugin/in_tail.rb
Line 151 in 5a7d949
Docs Changes:
Release Note:
same as title