Remove @metadata_list from buffer.rb
#2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is not used and a bit large overhead for performance. Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
|
I noticed fluentd/lib/fluent/plugin/buffer.rb Line 265 in f2b24f5 |
repeatedly
reviewed
Aug 15, 2019
lib/fluent/plugin/buffer.rb
Outdated
| end | ||
| log.trace "chunk purged", instance: self.object_id, chunk_id: dump_unique_id_hex(chunk_id), metadata: metadata | ||
| end | ||
|
|
||
| if metadata && metadata.timekey | ||
| @mutex.synchronize { del_timekey(metadata.timekey) } |
There was a problem hiding this comment.
@mutex.synchronize is called in del_timekey
There was a problem hiding this comment.
I forgot about it! thanks.
.5c81b40
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
Signed-off-by: Yuta Iwama <[email protected]>
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
I removed
@metada_listfrom buffer.rb since this ivar has almost no meaning. Moreover, this is an overhead since Buffer#add_metadata is called many times.Docs Changes:
no need
Release Note:
same as title