Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_server helper: Avoid re-define render_json #2517

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa [email protected]

Which issue(s) this PR fixes:
None

What this PR does / why we need it:
Avoid lots of warning in tests

Docs Changes:
No need

Release Note:
Same as title

@repeatedly repeatedly requested a review from ganmacs July 22, 2019 23:40
@repeatedly repeatedly self-assigned this Jul 22, 2019
Copy link
Member

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@repeatedly repeatedly merged commit 1474e1d into master Jul 23, 2019
@repeatedly repeatedly deleted the fix-redefine-warning branch July 23, 2019 09:40
repeatedly added a commit that referenced this pull request Jul 29, 2019
http_server helper: Avoid re-define render_json
Signed-off-by: Masahiro Nakagawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants