Add title to have unique thread name #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuta Iwama <[email protected]>
``` warning: net/http: Content-Type did not set; using application/x-www-form-urlencoded ``` Signed-off-by: Yuta Iwama <[email protected]>
repeatedly
reviewed
Jul 11, 2019
| # @param addr [String] Listen address | ||
| # @param port [String] Listen port | ||
| # @param logger [Logger] logger used in this server | ||
| # @param default_app [Object] This method must have #call. | ||
| def create_http_server(addr:, port:, logger:, default_app: nil) | ||
| def create_http_server(title:, addr:, port:, logger:, default_app: nil) |
There was a problem hiding this comment.
Normal argument is better for title argument. server and other helpers use normal argument in 1st position.
Signed-off-by: Yuta Iwama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
no
What this PR does / why we need it:
According to https://docs.fluentd.org/plugin-helper-overview/api-plugin-helper-thread#methods, create_thread receives
titlewhich must be unique as an argument and http_server_helper uses thread_helper internally.There are no problems now since http_server is used only by in_monitor plugin.
But we need to change http_server can change their name to have a unique name.
Docs Changes:
yes. need to add the description about
title.Release Note:
no