Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stats method #2491

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Improve stats method #2491

merged 2 commits into from
Jul 11, 2019

Conversation

repeatedly
Copy link
Member

Which issue(s) this PR fixes:
Follow up of #2450

What this PR does / why we need it:

  • queus_size / stage_size are updated by other thread so assigning these values to local variable is better
  • buffer_ prefix keys are static so avoid dynamic allocation for these keys.

Docs Changes:
No need

Release Note:
Improve the resource usage of Output/Buffer's statistics method

@repeatedly repeatedly added the enhancement Feature request or improve operations label Jul 10, 2019
@repeatedly repeatedly requested a review from ganmacs July 10, 2019 11:48
@repeatedly repeatedly self-assigned this Jul 10, 2019
Copy link
Member

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@repeatedly repeatedly merged commit 9f45c70 into master Jul 11, 2019
@repeatedly repeatedly deleted the improve-stats-method branch July 11, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants