socket helper: Support connect_timeout for TCP/TLS #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out_forward also supports connect_timeout parameter Signed-off-by: Masahiro Nakagawa <[email protected]>
repeatedly
force-pushed
the
socket-connect-timeout
branch
from
24cefc3 to
e6b3006
Compare
ganmacs
reviewed
Jun 20, 2019
| sock = WrappedSocket::TCP.new(host, port) | ||
| def socket_create_tcp(host, port, resolve_name: false, connect_timeout: nil, **kwargs, &block) | ||
| sock = if connect_timeout | ||
| s = ::Socket.tcp(host, port, connect_timeout: connect_timeout) |
There was a problem hiding this comment.
when and who will close this socket if it is set false to autoclose?
Ah, WrappedSocket::TCP will close this socket.
|
TLS supports connect_timeout via TCP socket creation. |
ganmacs
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out_forward also supports connect_timeout parameter
Signed-off-by: Masahiro Nakagawa [email protected]
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
Docs Changes:
After release v1.6.0, need to add connect_timeout parameter to socket helper/out_forward article.
Release Note:
socket helper/out_forward: Support connect_timeout parameter