Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollback_count should be incremented when takeback_chunk succeeded #2462

Merged
merged 1 commit into from
Jun 18, 2019
Merged

rollback_count should be incremented when takeback_chunk succeeded #2462

merged 1 commit into from
Jun 18, 2019

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Jun 18, 2019

Which issue(s) this PR fixes:
no

What this PR does / why we need it:

Increment @rollback_count when @buffer.takeback_chunk(chunk.unique_id) succeeded.

Docs Changes:

no

Release Note:

no

@ganmacs ganmacs requested a review from repeatedly June 18, 2019 06:32
@repeatedly repeatedly merged commit 25b081c into fluent:master Jun 18, 2019
@repeatedly
Copy link
Member

Thanks!

@ganmacs ganmacs deleted the inc-rollback-metrics branch June 19, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repeatedly repeatedly Awaiting requested review from repeatedly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganmacs @repeatedly