Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage local plugin #2409

Merged
merged 2 commits into from
May 13, 2019
Merged

Conversation

repeatedly
Copy link
Member

Which issue(s) this PR fixes:
Fixes #2373

What this PR does / why we need it:

  • Ignore empty file
  • Add fsync call in save

Docs Changes:
No need

Release Note:
storage_local: fluentd starts even if existing file is empty.
storage_local: Call fsync in save for XFS

@repeatedly repeatedly added the enhancement Feature request or improve operations label May 10, 2019
@repeatedly repeatedly requested a review from ganmacs May 10, 2019 01:17
@repeatedly repeatedly self-assigned this May 10, 2019
@repeatedly repeatedly merged commit 6e80961 into master May 13, 2019
@repeatedly
Copy link
Member Author

Thanks for the reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on XFS might not be able to read local storage pos file after crash
3 participants