Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config delimiter in syslog plugin #2378

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

abenbachir
Copy link
Contributor

@abenbachir abenbachir commented Apr 10, 2019

There are softwares out there that still use NUL-terminating characters when sending events through TCP. Firewalls for example are used a lots, and it's impossible to change their behavior because they are closed source. Most Firewall implement RFC3164 or CEF protocol, so using in_syslog plugin comes very usefull than in_tcp plugin.
I'm adding delimiter we can edit the default delimiter ("\n") from configuration, similar to in_tcp plugin.

I made the change in v0.12, I can do the same for v1.x If this change is good to merge.

Something important to know is that NUL(\0) or newline(\n) characters must be used with double-quote in configuration:

<source>
    type syslog
    protocol_type tcp
    delimiter "\0"
</source>

Docs Changes:
I will update documentation when this PR make it

@abenbachir abenbachir force-pushed the syslog-support-delimiter branch from acabadd to 1d7009e Compare April 10, 2019 18:54
@repeatedly
Copy link
Member

v0.12 will merge only security fix so please send this patch to master.

@abenbachir
Copy link
Contributor Author

abenbachir commented Apr 10, 2019

So you mean, this change will only make it to v1.x ?

@repeatedly
Copy link
Member

Yes.

@abenbachir abenbachir force-pushed the syslog-support-delimiter branch from 1d7009e to 31c8fcd Compare April 10, 2019 21:07
@abenbachir abenbachir changed the base branch from v0.12 to master April 10, 2019 21:07
Signed-off-by: Abderrahmane Benbachir <[email protected]>
@abenbachir abenbachir force-pushed the syslog-support-delimiter branch from 31c8fcd to 3e4327a Compare April 10, 2019 21:09
@abenbachir
Copy link
Contributor Author

Done

@repeatedly repeatedly merged commit 607c43c into fluent:master Apr 11, 2019
@repeatedly
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants