Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop dig_rb and update required ruby version to 2.3 #2372

Closed
wants to merge 2 commits into from

Conversation

henrich
Copy link

@henrich henrich commented Apr 7, 2019

ruby2.3 or higher version has dig_rb gem function as default, see top of https://github.com/jrochkind/dig_rb/blob/master/README.md

Now distros support ruby2.3 or higher version, bump up it would be okay, IMO.

@repeatedly
Copy link
Member

Thanks for the patch.

The problem is we can't drop older ruby support without annoucement.
One idea is drop ruby 2.1/2.2 support in this year. In addition, drop one old ruby version in each year.
2020 drops ruby 2.3. 2012 drops ruby 2.4, ...

@henrich
Copy link
Author

henrich commented Apr 9, 2019

Make sense, I got it.
How about raise another issue to drop old ruby version and depends on it?

@ganmacs
Copy link
Member

ganmacs commented Jan 6, 2020

Now, we can drop dig-rb. could you update this branch?

@repeatedly
Copy link
Member

#2750 includes these changes.
So we can close.

Thanks for the patch and suggestion!

@repeatedly repeatedly closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants