Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just tiny typo (grammar) #2369

Merged
merged 1 commit into from
May 10, 2019
Merged

just tiny typo (grammar) #2369

merged 1 commit into from
May 10, 2019

Conversation

Hearen
Copy link
Contributor

@Hearen Hearen commented Apr 4, 2019

Signed-off-by: Hearen [email protected]

Which issue(s) this PR fixes:
Fixes # just tiny typo (grammar)

What this PR does / why we need it:

Docs Changes: no

Release Note: no

@Hearen
Copy link
Contributor Author

Hearen commented Apr 4, 2019

@cosmo0920 Sorry for the inconvenience, just signed.

@repeatedly
Copy link
Member

repeatedly commented Apr 4, 2019

Please fix tests. test_filter_parser.rb checks error message.

In addition, don't open new PR for commit fix. Use git push -f for in-place commit update.
Lots of same PR are messy for repository search.

@Hearen
Copy link
Contributor Author

Hearen commented Apr 5, 2019

@repeatedly Good morning ;)

Sorry my bad, I knew how to do that. The old one is done in page directly while the second in my PC. I will avoid that, sorry for the inconvenience.

@Hearen
Copy link
Contributor Author

Hearen commented Apr 5, 2019

@repeatedly It seems it's still not passing the tests after updating the test_filter_parser.rb, is there anything I missed out? Sorry to ask this but I got confused now.

Locally I tested it with 100% passed

.............................................................
........................................................................
Finished in 1065.899145476 seconds.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2893 tests, 11518 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 1 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2.71 tests/s, 10.81 assertions/s
hearen@hearen-pc:~/git/personal/fluentd(typo-fix)$ bundle exec rake test

@repeatedly
Copy link
Member

This will be merged when release v1.5.0. Error message change is not trivial fix for users.

@repeatedly repeatedly merged commit 77983d0 into fluent:master May 10, 2019
@repeatedly
Copy link
Member

Next release is 1.5.0 so merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants