Fix plugin log time format if format is JSON #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time format for a plugin logger was out of sync with the parent logger, and the delegation of #time_format and #time_format= made it impossible to fix the plugin logger's time format without hacks. This problem was not noticeable if the log format was text, because time formatting was delegated via #caller_line to the parent logger. However, in the case of JSON output, the plugin logger's #format_time method was called, yielding incorrectly-formatted timestamps. Added tests for both text and JSON, and added tests for format changes in general while I was in there. Signed-off-by: Owen Smith <[email protected]>
|
Thanks for the patch. Will check. |
Signed-off-by: Owen Smith <[email protected]>
|
I confirmed this patch works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2355
The time format for a plugin logger was out of sync with the parent logger, and the delegation of
#time_formatand#time_format=made it impossible to fix the plugin logger's time format without hacks.This problem was not noticeable if the log format was text, because time formatting was delegated via
#caller_lineto the parent logger. However, in the case of JSON output, the plugin logger's#format_timemethod was called, yielding incorrectly-formatted timestamps.Added tests for both text and JSON, and added tests for format changes in general while I was in there.