Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: Add MessagePack::UnpackError to unrecoverable case #2301

Merged
merged 1 commit into from
Feb 21, 2019
Merged

output: Add MessagePack::UnpackError to unrecoverable case #2301

merged 1 commit into from
Feb 21, 2019

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented Feb 20, 2019 •
edited
Loading

Output plugin can't recover broken msgpack so it should be unrecoverable error.
See: fluent/fluent-plugin-kafka#243

This PR includes small enchancement for unrecoverable error test.

Signed-off-by: Masahiro Nakagawa [email protected]

@repeatedly repeatedly added the bug Something isn't working label Feb 20, 2019
@repeatedly repeatedly self-assigned this Feb 20, 2019
@repeatedly repeatedly requested a review from okkez February 20, 2019 15:33
okkez
okkez approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@okkez okkez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@repeatedly repeatedly merged commit 640aefb into master Feb 21, 2019
@ganmacs ganmacs deleted the add-msgpack-unpack-error-to-unrecoverable branch July 11, 2019 08:02
@repeatedly repeatedly mentioned this pull request Jul 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okkez okkez okkez approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @okkez