Use String#squeeze instead of String#gsub #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because String#squeeze is about 7x faster than String#gsub. See also https://gist.github.com/okkez/6e199011505c6db7e2e1003cc94f8cbc Signed-off-by: Kenji Okimoto <[email protected]>
|
I will send a PR for #1862 after this PR is merged. |
|
I first knew this method :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because String#squeeze is about 7x faster than String#gsub.
See also https://gist.github.com/okkez/6e199011505c6db7e2e1003cc94f8cbc