Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check secondary type to avoid unexpected error. fix #2167 #2169

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

repeatedly
Copy link
Member

See #2167

This change includes one more change to use sub_test_case for secondary tests.

Signed-off-by: Masahiro Nakagawa <[email protected]>
@repeatedly repeatedly self-assigned this Nov 7, 2018
@repeatedly repeatedly added bug Something isn't working v1 labels Nov 7, 2018
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I've confimed that Fluent::ConfigError occurs when non-buffered is spefied in secondary.

@repeatedly repeatedly merged commit 0751902 into master Nov 8, 2018
@repeatedly repeatedly deleted the check-secondary-type branch November 8, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants