in_syslog: Support octet counting frame. fix #1679 #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
repeatedly
commented
Oct 15, 2018
lib/fluent/plugin/in_syslog.rb
Outdated
| @@ -75,6 +75,8 @@ class SyslogInput < Input | |||
| config_param :tag, :string | |||
| desc 'The transport protocol used to receive logs.(udp, tcp)' | |||
| config_param :protocol_type, :enum, list: [:tcp, :udp], default: :udp | |||
| desc 'The message frame type.(normal, octet_count)' | |||
| config_param :frame_type, :enum, list: [:normal, :octet_count], default: :normal | |||
There was a problem hiding this comment.
I want better name for normal.
There was a problem hiding this comment.
I think so, too.
How about older or traditional?
There was a problem hiding this comment.
traditional seems good. Will change soon.
cosmo0920
reviewed
Oct 16, 2018
Signed-off-by: Masahiro Nakagawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
frame_typeparameter to accept octet counting.If set
frame_type octet_countin the configuration,in_syslogcan accept octet counting messag from senders.Signed-off-by: Masahiro Nakagawa [email protected]