Fix in_monitor_agent's buffer_total_queued_size #1990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Now, in_monitor_agent's buffer_total_queued_size does't count queued chunk's sizes.
So fix for counting them.
Problem
Version: Fluent1.1.3
Buffer Settings
dropping oldest chunk to make space after buffer overflow
, in_monitor agent returned below results.Queued total buffer size was about 2400mb, but in_monitor_agent's output was under 40mb, they were significantly different.
Reason
in_monitor_agent counts only stage_size, does't count queue_size.
https://github.com/fluent/fluentd/blob/v1.1.3/lib/fluent/plugin/in_monitor_agent.rb#L282
Fix detail
Fix in_monitor_agent's buffer_total_queued_size for counting queued chunk's sizes.
Fixed environment, in_monitor_agent's output was below, about 2400mb.