Fix DataError exception #1984
Closed
Fix DataError exception #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
added a commit
that referenced
this pull request
Nov 8, 2018
Thread#run causes unexpected interruption and it affects the behaviour of some libraries, e.g. DataError in zlib. Use condition variable instead to handle thread execution. This change is based on jl2005's #1984 patch. Signed-off-by: Masahiro Nakagawa <[email protected]>
|
This patch has a bug of thread control so I wrote new patch based on this change and merged. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1903 #1847
This exception is caused by
submit_flush_oncewake up the output thread and interrupting gzip compression, causing aDataErrorexception to be thrown in theclose.