Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pattern start with character classes #1887

Merged

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Mar 12, 2018

In prevous version, following pattern raises syntax error:

<filter>
  @type grep
  <regexp>
    key price
    pattern [1-9]\d*
  </regexp>
</filter>

This example is derrived from filter-grep

In prevous version, following pattern raises syntax error:

    <filter>
      @type grep
      <regexp>
        key price
        pattern [1-9]\d*
      </regexp>
    </filter>

This example is derrived from
https://docs.fluentd.org/v1.0/articles/filter_grep#<regexp>-directive
@okkez
Copy link
Contributor Author

okkez commented Mar 12, 2018

On the other hand, we want to use regular expression in configuration file sometimes.
So, should we support config_param :pattern, :regexp ?

@repeatedly
Copy link
Member

all tests failed.

@okkez
Copy link
Contributor Author

okkez commented Mar 13, 2018

Sorry, my fault...

@repeatedly repeatedly merged commit b999f80 into fluent:master Mar 15, 2018
@repeatedly
Copy link
Member

Thanks!

@okkez okkez deleted the support-pattern-start-with-character-classes branch November 16, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants