in_tail: Prevent IOHandler.on_notify() being called concurrently #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a fix for a multi-threading bug in Fluentd core. Apparently, this bug
has been one of major causes of the long-standing testing failures on Travis CI.
Problem
Essentially, there is a concurrency bug in the implementation of
in_tail
.While
IOHandler
(in_tail#L673) is not designed to be thread-safe, its methodon_notify
can be called by multiple threads concurrently.Here is how it occurs:
on_notify
on detach/shutdown (main thread)on_notify
on filesystem events(eventloop thread)
In this situation, one thread can see the data retrieved (and being actively
processed) by another thread, which will result in duplication of data records.
Solution
This patch fixes the issue by introducing a mutex, which should prevent two
threads from entering into the critical session simultaneously.