Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete nested field #1800

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Delete nested field #1800

merged 4 commits into from
Jan 9, 2018

Conversation

repeatedly
Copy link
Member

Additional feature for record_accessor.
This is useful for several mutation plugins.

Ref #1578

@repeatedly repeatedly added enhancement Feature request or improve operations v1 labels Dec 21, 2017
@repeatedly repeatedly self-assigned this Dec 21, 2017
@repeatedly repeatedly requested a review from mururu December 21, 2017 17:14
@repeatedly
Copy link
Member Author

@mururu Could you check this?

config = CONFIG + %[remove_keys $.nest.k1]
filtered = filter(config)
filtered.each_with_index do |(_t, r), i|
assert_not_include({'k2' => 'v2'}, r['nest'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be assert_not_include(r['nest'], 'k1').

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. just fixed.

@mururu
Copy link
Member

mururu commented Dec 28, 2017

Looks good.

@repeatedly repeatedly merged commit ccd971d into master Jan 9, 2018
@repeatedly repeatedly deleted the delete-nested-field branch January 9, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants