Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tail: Add enable_stat_watcher option to disable inotify events #1775

Merged
merged 3 commits into from
Dec 6, 2017

Conversation

repeatedly
Copy link
Member

inotify sometimes lost the events.
We want to investigate inotify in libev causes unexpected behaviour or not.
disable parameter is useful for it.

@repeatedly repeatedly requested a review from mururu December 6, 2017 04:47
@repeatedly repeatedly self-assigned this Dec 6, 2017
@repeatedly repeatedly added the enhancement Feature request or improve operations label Dec 6, 2017
@mururu
Copy link
Member

mururu commented Dec 6, 2017

@repeatedly Is it okay if both enable_stat_watcher and enable_watch_timer are false?

@repeatedly
Copy link
Member Author

Good catch. I added the validation.

Copy link
Member

@mururu mururu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@repeatedly repeatedly merged commit e8a1127 into master Dec 6, 2017
@repeatedly repeatedly deleted the in_tail-add-enable-stat-watcher-option branch March 9, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants