Combine before_shutdown and shutdown call in one sequence. #1763
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Output's flush_at_shutdown is executed in before_shutdown but in_tail's multiline buffered logs are flushed in shutdown. To avoid such problem, Input#shutdown should be called before Output#before_shutdown. If this approach doesn't resolve all cases, calling order will be changed to input, filter and output order like v0.12.
repeatedly
requested review from
tagomoris and
mururu
and removed request for
tagomoris
|
Right, removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Output's flush_at_shutdown is executed in before_shutdown but
in_tail's multiline buffered logs are flushed in shutdown.
This mismatch causes log lost at shutdown/restart.
To avoid such problem, Input#shutdown should be called before Output#before_shutdown.
If this approach doesn't resolve all cases,
calling order will be changed to v0.12 like sequence.
In addition, we will consider moving flush_at_shutdown routine to
shutdown.