Cleanup server helper #1759
Merged
Cleanup server helper #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
repeatedly
commented
Nov 22, 2017
repeatedly
commented
- Add error handling
- Reduce memory allocation
- Reuse built-in buffer
|
@mururu Could you check this? |
mururu
reviewed
Nov 22, 2017
lib/fluent/plugin_helper/server.rb
Outdated
| @@ -370,6 +370,8 @@ def server_create_udp_socket(shared, bind, port) | |||
| sock | |||
| end | |||
|
|
|||
| PEERADDR_FAILED = ["?", "?", "name resolusion failed", "?"] | |||
There was a problem hiding this comment.
Very minor comment: remote_port usually returns Integer, but it returns String when failed. It is a little confusing. So it seems better to have comment about that it may return string at remote_port definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.