Use config_section for filter_grep #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can use both `regexpN` and `<regexp>` section. But `regexpN` displays deprecation warnings on boot.
repeatedly
reviewed
Jul 5, 2017
lib/fluent/plugin/filter_grep.rb
Outdated
| end | ||
| end | ||
|
|
||
| def filter(tag, time, record) | ||
| result = nil | ||
| begin | ||
| catch(:break_loop) do | ||
| @regexps.each do |key, regexp| | ||
| @regexps.each do |e| |
There was a problem hiding this comment.
This implementation is slow.
Transform @regexps into @_regexps is better.
In previous verson:
Rehearsal -------------------------------------------
flat 0.080000 0.010000 0.090000 ( 0.091635)
section 0.100000 0.000000 0.100000 ( 0.101266)
---------------------------------- total: 0.190000sec
user system total real
flat 0.080000 0.000000 0.080000 ( 0.077353)
section 0.100000 0.000000 0.100000 ( 0.099207)
In this version:
Rehearsal -------------------------------------------
flat 0.080000 0.000000 0.080000 ( 0.076263)
section 0.070000 0.000000 0.070000 ( 0.068805)
---------------------------------- total: 0.150000sec
user system total real
flat 0.060000 0.000000 0.060000 ( 0.066826)
section 0.070000 0.000000 0.070000 ( 0.065660)
|
Thanks! @okkez Could you backport this change to v0.12? |
|
Sure. I will try it later. |
okkez
added a commit
to okkez/fluentd
that referenced
this pull request
Jul 13, 2017
Users can use both `regexpN` and `<regexp>` section. But `regexpN` displays deprecation warnings on boot. Backport fluent#1611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can use both
regexpNand<regexp>section.But
regexpNdisplays deprecation warnings on boot.