Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null byte in double-quoted string. fix #1358 #1552

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented Apr 26, 2017

We can use "\0" in formatter delimiter, in_tcp delimiter or anywhere.

Previous behaviour is raising error so this patch should not break existing configuration.

@repeatedly repeatedly self-assigned this Apr 26, 2017
@repeatedly repeatedly added v0.12 v0.14 enhancement Feature request or improve operations labels Apr 26, 2017
@repeatedly repeatedly requested a review from mururu April 26, 2017 23:41
Copy link
Member

@mururu mururu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@repeatedly repeatedly merged commit f1272c4 into master Apr 28, 2017
@repeatedly repeatedly deleted the allow-null-byte branch May 9, 2017 20:27
repeatedly added a commit that referenced this pull request May 22, 2017
Allow null byte in double-quoted string. fix #1358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.12 v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants