Add formatted_to_msgpack_binary? to Output plugin API. fix #1538 #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mururu Could you also check this patch? |
|
@repeatedly sure. |
mururu
reviewed
Apr 19, 2017
| test 'plugin using custom format cannot iterate chunk in #write' do | ||
| data('formatted_to_msgpack_binary?' => :custom, | ||
| 'formatted_to_msgpack_binary' => :old_custom) | ||
| test 'plugin using custom format cannot iterate chunk in #write' do |out_type| |
There was a problem hiding this comment.
This testcase doesn't verify this change because @format_type_is_msgpack.call always returns false regardless of overriding #formatted_to_msgpack_binary?.
|
This test case is better to add tests for |
|
You are right. I just changed test case. |
|
LGTM |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.