Add config param option validator #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly could you review this change? |
|
LGTM |
tagomoris
force-pushed
the
add-config_param-option-validator
branch
from
ba00eee to
19c60be
Compare
|
Rebased. I'll merge this after CI green. |
|
Let me merge this, because failing CI on AppVeyor is about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, plugin authors can add any keyword options on
config_paramandconfig_argument, and these are not checked.This may occur that plugin author want to set any options, but it doesn't work well by typo or any other reasons.
So I added a validator for these options, not to be set unexpected parameter options.