Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record_transformer: remove_keys processing should be last #1433

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

repeatedly
Copy link
Member

Currently, remove_keys doesn't work with renew_time_key parameter, so
user needs one more filter to remove renew_time_key field from the record.

<filter pattern>
  @type record_transformer
  renew_time_key event_time
  auto_typecast true
  <record>
    event_time ${Convert record["time_str"] into unixtime or float type}
  </record>
</filter>

<filter pattern>
  @type record_transformer
  remove_keys event_time
</filter>

This is verbose and not good performance. remove_keys should remove renew_time_key.

<filter pattern>
  @type record_transformer
  renew_time_key event_time
  remove_keys event_time
  auto_typecast true
  <record>
    event_time ${Convert record["time_str"] into unixtime or float type}
  </record>
</filter>

@repeatedly repeatedly requested a review from sonots January 25, 2017 22:54
@repeatedly repeatedly added the enhancement Feature request or improve operations label Jan 25, 2017
@repeatedly
Copy link
Member Author

@sonots Could you check this patch?

@sonots
Copy link
Member

sonots commented Jan 26, 2017

LGTM

@repeatedly repeatedly merged commit 1adaa0f into master Jan 26, 2017
repeatedly added a commit that referenced this pull request Feb 1, 2017
record_transformer: remove_keys processing should be last
@repeatedly repeatedly deleted the move-remove-keys-to-last branch March 9, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants