Rename parameter names with the rule of other params #1412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to rename two buffer parameters:
chunk_records_limit
->chunk_limit_records
queue_length_limit
->queue_limit_length
These new names are named under the same rule with other parameters:
chunk_limit_size
total_limit_size
Once (in very early era in v0.14) these parameters were renamed from
chunk_size_limit
andtotal_size_limit
with consultation of some English native speakers, but some others were unchanged at that time.But I think these should be named under the same rule for consistency.
These parameters are still undocumented, so I believe we can do it now, only right now.