fix bug about chunk response handling #1389
Conversation
|
@repeatedly could you review this? |
| @@ -214,22 +214,23 @@ def write(chunk) | |||
| select_a_healthy_node{|node| node.send_data(tag, chunk) } | |||
| end | |||
|
|
|||
| ACKWaitingSockInfo = Struct.new(:sock, :chunk_id, :node, :time, :timeout) do | |||
| ACKWaitingSockInfo = Struct.new(:sock, :chunk_id, :chunk_id_base64, :node, :time, :timeout) do | |||
There was a problem hiding this comment.
Just one idea.
How about using def chunk_id_base64 instead of struct member?
It reduces additional member cost.
There was a problem hiding this comment.
It's not bad idea, but it looks better for me to add these methods to chunk:
unique_id_hexunique_id_base64
These values are called many times (especially _hex for logging), and should be cached not to calculate 2 or more times.
How do you think about it?
There was a problem hiding this comment.
Another one: chunk.unique_id(:hex) (or :base64)
There was a problem hiding this comment.
I like method approach, unique_id_hex, rathar than unique_id(:hex).
There was a problem hiding this comment.
Fixing this point makes many bad things (one is unreasonable SEGV in Travis) and doesn't bring so big happy.
I'll leave this as is.
| @@ -178,7 +178,7 @@ def start | |||
| # But it should be overwritten by ack_response_timeout to rollback chunks after timeout | |||
| if @ack_response_timeout && @delayed_commit_timeout != @ack_response_timeout | |||
| log.info "delayed_commit_timeout is overwritten by ack_response_timeout" | |||
There was a problem hiding this comment.
OT. Adding why message is better for users to understand why delayed_commit_timeout is overwritten in out_forward.
| @@ -178,7 +178,7 @@ def start | |||
| # But it should be overwritten by ack_response_timeout to rollback chunks after timeout | |||
| if @ack_response_timeout && @delayed_commit_timeout != @ack_response_timeout | |||
There was a problem hiding this comment.
If @delayed_commit_timeout and @ack_response_timeout are the same, @delayed_commit_timeout = @ack_response_timeout + 2 line is skipped. Is this okay?
There was a problem hiding this comment.
ok, because these are configured intentionally by users, and don't cause problems for longer configured values.
tagomoris
force-pushed
the
fix-bug-forward-ack-reponse
branch
from
e295e70 to
0579cce
Compare
fixes #1388.
v0.14.11 should be released after this change is merged for quick regression fix.
The changes between v0.14.10 release and this change will be introduced at v0.14.12.