Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise ConfigError when fields parameter is empty array #1369

Merged
merged 2 commits into from
Dec 14, 2016
Merged

raise ConfigError when fields parameter is empty array #1369

merged 2 commits into from
Dec 14, 2016

Conversation

repeatedly
Copy link
Member

No description provided.

@repeatedly repeatedly requested a review from tagomoris December 14, 2016 00:32
@repeatedly repeatedly added enhancement Feature request or improve operations v0.14 labels Dec 14, 2016
@tagomoris
Copy link
Member

This code doesn't raise errors for configurations including both of empty string and non-empty string: fields a,,b.
Is it intentional?

@repeatedly
Copy link
Member Author

Yes

@tagomoris
Copy link
Member

Okay. LGTM.

@repeatedly repeatedly merged commit bb685e6 into master Dec 14, 2016
@repeatedly repeatedly deleted the csv-raise-empty-field branch December 14, 2016 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagomoris tagomoris Awaiting requested review from tagomoris

Assignees

@tagomoris tagomoris

Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @tagomoris