Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close files explicitly in in_tail #1327

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

tagomoris
Copy link
Member

File handles are not closed explicitly now, and it makes troubles on Windows (especially in tests).
After detaching watchers (and stops all threads including event loop), no threads touches to IO objects and file handlers.
File handles should be closed after that.

…ence

File handles are not closed explicitly now, and it makes troubles on Windows (especially in tests).
After detaching watchers (and stops all threads including event loop), no threads touches to IO objects
and file handlers.
File handles should be closed after that.
@tagomoris
Copy link
Member Author

I'm seriously confused about why #1312 fails on Windows CI only with ruby 2.1 and 2.2, but root cause of that problem is not to close files in IOHandler.
This change fixes that problem.

@tagomoris
Copy link
Member Author

@repeatedly could you check this?

@repeatedly
Copy link
Member

Will check :)

@tagomoris
Copy link
Member Author

@repeatedly ping

@repeatedly
Copy link
Member

LGTM

@tagomoris
Copy link
Member Author

Failing CI task is fixed at #1331.

@tagomoris tagomoris merged commit a0c4687 into master Nov 28, 2016
@tagomoris tagomoris deleted the close-files-after-detaching-watchers-in-in_tail branch November 28, 2016 06:30
@tagomoris tagomoris mentioned this pull request Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants