Close files explicitly in in_tail #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence File handles are not closed explicitly now, and it makes troubles on Windows (especially in tests). After detaching watchers (and stops all threads including event loop), no threads touches to IO objects and file handlers. File handles should be closed after that.
|
I'm seriously confused about why #1312 fails on Windows CI only with ruby 2.1 and 2.2, but root cause of that problem is not to close files in IOHandler. |
|
@repeatedly could you check this? |
|
Will check :) |
|
@repeatedly ping |
|
LGTM |
|
Failing CI task is fixed at #1331. |
tagomoris
deleted the
close-files-after-detaching-watchers-in-in_tail
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File handles are not closed explicitly now, and it makes troubles on Windows (especially in tests).
After detaching watchers (and stops all threads including event loop), no threads touches to IO objects and file handlers.
File handles should be closed after that.